Repository navigation
solver: fix on-demand CDI device resolution - #7293
Merged
Merged
Conversation
Only include on-demand devices requested by the build, preserving their names, selectors, and optional flags. Defer resolution until setup has registered the devices so required requests can reach the installer. Skip unresolved on-demand kinds when checking explicit grants alongside registered devices. Keep permission checks for installed devices intact. Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
fix-cdi-on-demand-resolution
branch
from
October 17, 2026 14:50
b675c35 to
016bab5
Compare
crazy-max
marked this pull request as ready for review
October 19, 2026 08:38
tonistiigi
reviewed
Oct 21, 2026
Resolve registered class matches before deferring on-demand devices, and enforce their device permissions. Ignore nil device requests. Add regression coverage for denied matches and explicit grants. Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com> Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Member
Author
Yes I missed the class-annotation fallback |
tonistiigi
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Entitlement validation currently adds every available on-demand CDI kind to a build device requests, even when the build requested an unrelated device. It also replaces the original requests with bare kind names, losing selectors such as
=alland the optional flag. Required requests have the opposite problem where validation tries to resolve them before setup has registered the devices, so they fail with "required device … is not registered" without reaching the installer. This change retains only matching requests and preserves their names until setup completes. Explicit grants for on-demand kinds also stop failing premature resolution when a build requests registered devices alongside them. Existing permission checks for installed devices remain unchanged.